Quick reviews are a way of checking that a piece of code is at the level that the author's comment at its start says it is. All quick reviewers must fully understand IC so that they know what they're seeing.
How to Do a Quick Review
The levels that are toughest to judge are ICL 6, 7, and 8. Here are some guidelines to use for a quick review.
ICL 6 Quick Review Questions
- Do the class, methods, and instance variables have specs?
- Does the class spec have an MSS?
- Does the MSS mention all the methods?
- Do the method specs have complete pre and postconditions?
- Do the instance variables have invariants where needed?
ICL 7 Quick Review Questions
- Does each method and those it calls refer only to variables mentioned in the conditions?
- Do all uses of instance variables seem to obey their invariants?
- Are method implementations not long (must be 80 lines at most unless very structured)?
ICL 8 Quick Review Questions
- Are method implementations short (no more than 10 lines per spec or 10 lines per method where intramethod specs aren't used)?
- Are the specs short?
- Do the specs have clearly identifiable clauses?
- Are the conditions written with testable wording?
- Does the MSS seem to list every possible calling sequence?
| || |
March 25, 1996: created.
Copyright © 1996,
All Rights Reserved